Applicants API is broken

[Yang]

https://politicsandwar.com/api/applicants/790

 

If you look carefully, there's no comma after a nation. 

 

{"nationid":57724,"nation":"Atlantica","leader":"Loozianajay","continent":"North America","cities":5,"score":340}{"nationid":59099,"nation":"Naxiznevi","leader":"Silverfrost","continent":"Europe","cities":3,"score":184}

 

should really be

{"nationid":57724,"nation":"Atlantica","leader":"Loozianajay","continent":"North America","cities":5,"score":340},{"nationid":59099,"nation":"Naxiznevi","leader":"Silverfrost","continent":"Europe","cities":3,"score":184}

 

Alternatively, you could also add the allianceposition from the /nation/ endpoint to the /nations/ endpoint, so we don't have to open up every single nations in a list to see whether they're an applicant.

 

Thank you!

[Shakyr]

Yeah we've been trying for months to get the API to be consistent. Good luck

 

I've got notes around somewhere on each of the API endpoints, what they should be for consistency. Even posted a few of them.

[Alex]

I've got this fixed locally, and I'll add the allianceposition field to the nations api. Should be pushed live soon.

 

For the record, the alliance position field takes values 0-5, each corresponding to the following:

 

0 : No Position (should only happen for nations not in an alliance)

1: Applicant

2: Member

3: Officer

4: Heir

5: Leader

[hadesflames]

How did this even happen? There are typically functions that take care of this for you...

[Yang]

Thanks, much appreciated!

[Alex]

How did this even happen? There are typically functions that take care of this for you...

 

Forgot to increment the comma counter on this script.