Small Alliances API Issue

[Printer635]

Hi Alex,

 

At around this time in the morning (11 am GMT), alliances that have recently deleted are still visible in the API but their score value disappears resulting in a key value error.

 

EG 1: {"id":"3936","founddate":"2016-12-19 19:04:37","name":"Mono","acronym":"","color":"aqua","continent":"Europe","rank":115,"avgscore":0,"flagurl":"https:\/\/politicsandwar.com\/img\/flags\/americansomoa.jpg","forumurl":"","ircchan":""}

 

EG 2: {"id":"3911","founddate":"2016-12-15 03:16:01","name":"Loner","acronym":"","color":"black","continent":"Europe","rank":112,"avgscore":0,"flagurl":"https:\/\/i.imgur.com\/ntCnXWy.png","forumurl":"","ircchan":""}

 

Given "avgscore" is still there it should be easy enough to include "score":0 until the API updates and removes the alliance entry.

 

Also as I'm here, you could annoy everyone by changing the "ircchan" key name to something discord related now *runs away*

 

Ta,

 

Printer

 

 

 

 

[Shakyr]

You should be checking for the existence of the key first anyways, before referencing it. Keys have been renamed in the past.

 

Hopefully the issue with deleted alliances showing up in the API will get resolved soon, though.

[Alex]

Deleted alliances can't show up in the API. If you're seeing them in the API, they haven't been deleted yet.

[Printer635]

Deleted alliances can't show up in the API. If you're seeing them in the API, they haven't been deleted yet.

 

Managed to nab some evidence, it says in game the alliances have been deleted when I follow the id given by the API(See Below)

 

{"id":"3922","founddate":"2016-12-16 16:13:11","name":"The Alliance of the Tri-force","acronym":"","color":"red","continent":"Europe","rank":154,"avgscore":0,"flagurl":"https:\/\/politicsandwar.com\/img\/flags\/canada.jpg","forumurl":"","ircchan":""}

 

[Shakyr]

Is there a delay between having no members (and generating that warning ingame), before it gets cleaned up? That would explain the issue.

Edited March 5, 2017 by Shakyr

[Alex]

When you view an alliance page with no members, it deletes the alliance. If you try to look at the API after you've looked at the alliance, it won't be there.

[Shakyr]

When you view an alliance page with no members, it deletes the alliance. If you try to look at the API after you've looked at the alliance, it won't be there.

Is it possible to add a check then, if you request an alliance via the API, with no members, it deletes the alliance and serves back an error?